[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 1/2] public/io/netif.h: document transmit and receive wire formats separately



> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 11 January 2016 15:53
> To: Paul Durrant
> Cc: Ian Campbell; Ian Jackson; xen-devel@xxxxxxxxxxxxxxxxxxxx; Keir
> (Xen.org); Tim (Xen.org)
> Subject: Re: [PATCH v5 1/2] public/io/netif.h: document transmit and receive
> wire formats separately
> 
> >>> On 11.01.16 at 16:25, <paul.durrant@xxxxxxxxxx> wrote:
> > Currently there is no documented wire format for guest receive-side
> > packets but the location of the 'wire format' comment block suggests
> > it is the same as transmit-side. This is almost true but there is a
> > subtle difference in the use of the 'size' field for the first fragment.
> >
> > For clarity this patch creates separate comment blocks for receive
> > and transmit side packet wire formats, tries to be more clear about the
> > distinction between 'fragments' and 'extras', and documents the subtlety
> > concerning the size field of the first fragment.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Keir Fraser <keir@xxxxxxx>
> > Cc: Tim Deegan <tim@xxxxxxx>
> > ---
> >
> > v5:
> >  - Add extra clarifications.
> 
> Di you perhaps not notice that v4 went in, and hence an incremental
> patch would be needed?

Nope, clearly I didn't. I did not see an Acked-by so I didn't check.

I'll send v6 with an incremental patch.

  Paul

> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.