[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 3/3] libxl: info: Display build_id of the hypervisor.
On Thu, Jan 07, 2016 at 09:25:20PM -0500, Konrad Rzeszutek Wilk wrote: > If the hypervisor is built with we will display it. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> > --- > v2: Include HAVE_*, use libxl_zalloc, s/rc/ret/ > --- > tools/libxl/libxl.c | 24 ++++++++++++++++++++++++ > tools/libxl/libxl.h | 5 +++++ > tools/libxl/libxl_types.idl | 1 + > tools/libxl/xl_cmdimpl.c | 1 + > 4 files changed, 31 insertions(+) > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > index 9207621..b894c1f 100644 > --- a/tools/libxl/libxl.c > +++ b/tools/libxl/libxl.c > @@ -5263,6 +5263,7 @@ libxl_numainfo *libxl_get_numainfo(libxl_ctx *ctx, int > *nr) > > const libxl_version_info* libxl_get_version_info(libxl_ctx *ctx) > { > + GC_INIT(ctx); > union { > xen_extraversion_t xen_extra; > xen_compile_info_t xen_cc; > @@ -5270,8 +5271,10 @@ const libxl_version_info* > libxl_get_version_info(libxl_ctx *ctx) > xen_capabilities_info_t xen_caps; > xen_platform_parameters_t p_parms; > xen_commandline_t xen_commandline; > + xen_build_id_t build_id; > } u; > long xen_version; > + int ret; > libxl_version_info *info = &ctx->version_info; > > if (info->xen_version_extra != NULL) > @@ -5304,6 +5307,27 @@ const libxl_version_info* > libxl_get_version_info(libxl_ctx *ctx) > xc_version(ctx->xch, XENVER_commandline, &u.xen_commandline); > info->commandline = strdup(u.xen_commandline); > > + u.build_id.len = sizeof(u) - sizeof(u.build_id); > + ret = xc_version(ctx->xch, XENVER_build_id, &u.build_id); > + switch ( ret ) { > + case -EPERM: > + case -ENODATA: > + case 0: > + info->build_id = strdup(""); I guess you're following existing strdup examples in this function. Since now there is a GC in scope, you can use libxl__strdup. Presumably you can also change other instances to use libxl__strdup. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |