Re: [Xen-devel] [PATCH v2 1/3] checkpatch.pl: add missing memory barriers

[Joe Perches <joe@xxxxxxxxxxx>]

On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote:
> On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote:
> > SMP-only barriers were missing in checkpatch.pl
> > 
> > Refactor code slightly to make adding more variants easier.
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> If I use a variable called $smp_barriers, I'd expect
> it to actually be the smp_barriers, not to have to
> prefix it with smp_ before using it.
> 
>               my $smp_barriers = qr{
>                       smp_store_release|
>                       smp_load_acquire|
>                       smp_store_mb|
>                       smp_read_barrier_depends

That's missing (?:barriers) too.

btw: shouldn't this also have
        smp_mb__(?:before|after)_atomic
?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel