[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/2] build: convert NR_CPUS to Kconfig
On 08/01/16 23:17, Doug Goldstein wrote: > diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c > index 7f89694..9207179 100644 > --- a/xen/common/spinlock.c > +++ b/xen/common/spinlock.c > @@ -246,7 +246,7 @@ int _spin_trylock_recursive(spinlock_t *lock) > unsigned int cpu = smp_processor_id(); > > /* Don't allow overflow of recurse_cpu field. */ > - BUILD_BUG_ON(NR_CPUS > 0xfffu); > + BUILD_BUG_ON(CONFIG_NR_CPUS > 0xfffu); > > check_lock(&lock->debug); > Talking of recursive spinlocks, this check has a fencepost error. I have submitted a cleanup patch, subject "xen/spinlock: Use mnemonics for recursive spinlock sentinel values", which also fixes this bug. It is going to conflict with this change. I don't mind rebasing, depending on which patch gets accepted first. Everything else looks fine. Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |