Re: [Xen-devel] [PATCH v4 3/3] public/io/netif.h: document new extra info for passing hash values

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2016-01-07 at 13:05 +0000, Paul Durrant wrote:
>Â
> Â/*
> + * Hash types. (See NETIF_CTRL_TOEPLITZ_FLAG_* definitions above
> + * for more information).
> + */
> +#define XEN_NETIF_HASH_TYPE_NONEÂÂÂÂÂÂÂÂ0
> +#define XEN_NETIF_HASH_TYPE_IPV4ÂÂÂÂÂÂÂÂ1
> +#define XEN_NETIF_HASH_TYPE_IPV4_TCPÂÂÂÂ2
> +#define XEN_NETIF_HASH_TYPE_IPV6ÂÂÂÂÂÂÂÂ3
> +#define XEN_NETIF_HASH_TYPE_IPV6_TCPÂÂÂÂ4

Should these be TYPE_TOEPLITZ_FOO? I suppose there are other possible TCPv4
hashes for example.

Perhaps a comment along the lines "XEN_NETIF_HASH_TYPE_TOEPLITZ_*
corresponds precisely to the bit positions ofÂNETIF_CTRL_TOEPLITZ_FLAG_*
values", or even defining one in terms of the other?

The control side (previous patch) has a toeplitz specific mechanism, with
individual hash bits with it, whereas this is presented more as a generic
hash mechanism with specific bits corresponding to toeplitz hashes.
i.e.ÂNETIF_CTRL_TOEPLITZ* vsÂXEN_NETIF_EXTRA_TYPE_HASH. Seems like a
wrinkle, but I'm not sure if its an important one.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel