Re: [Xen-devel] [PATCH v5] x86/VPMU: implement ipc and arch filter flags

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.01.16 at 22:40, <bgregg@xxxxxxxxxxx> wrote:
> On Thu, Jan 7, 2016 at 6:12 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> >>> On 05.01.16 at 02:43, <bgregg@xxxxxxxxxxx> wrote:
>> > -#define XENPMU_FEATURE_INTEL_BTS  1
>> > +#define XENPMU_FEATURE_INTEL_BTS  (1<<0)
>> > +#define XENPMU_FEATURE_IPC_ONLY   (1<<1)
>> > +#define XENPMU_FEATURE_ARCH_ONLY  (1<<2)
>>
>> when I reached this: Do these additions really need to go here?
>> And if they do, why does do_xenpmu_op()'s XENPMU_feature_set
>> case not get altered?
>>
> 
> I'd say they do, as it's pmu.h, and it places them with the BTS feature,
> other PMU modes, etc. Unless I'm missing some consideration.
> 
> Yes, I missed the new sysfs PMU interface, so do_xenpmu_op() should do:
> 
>     case XENPMU_feature_set:
>         if ( pmu_params.val & ~(XENPMU_FEATURE_INTEL_BTS |
>                                 XENPMU_FEATURE_IPC_ONLY |
>                                 XENPMU_FEATURE_ARCH_ONLY))
>             return -EINVAL;
> 
> I can send along a v6 patch with the other changes too if that's desirable.

That's not just desirable, but what I would expect to happen. I'm
certainly not going to have a second go at fixing up the patch for
you.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel