Re: [Xen-devel] [PATCH v4 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue.

["Xu, Quan" <quan.xu@xxxxxxxxx>]

> On January 07, 2016 9:28 PM, <JBeulich@xxxxxxxx> wrote:
> >>> On 07.01.16 at 02:39, <quan.xu@xxxxxxxxx> wrote:
> > On January 06, 2016 7:26 PM, <quan.xu@xxxxxxxxx> wrote:
> >> > I didn't think about the full logic thoroughly now. But it would
> >> > always be good to not hide device now until a point where all
> >> > related states have been cleaned up in error handling path chained up.
> >> >
> >
> > Jan, could you help me to double check it? thanks.
> 
> I'm not sure I understand what you want or need, the more that I didn't even
> get around to look at the patches yet.
> 

Jan, 
Patch 2/3 and Patch 3/3 are based on v3 (Actually they are v3's patch 1/2 and 
patch 2/2).
We have discussed how to hide a device with pci_hide_device() when Device-TLB 
flush is error. 

Now there are 2 concerns:
      1. Hide the PCI device may break the code path. (then the pdev->domain is 
dom_xen)
      2. Is the blew logic right?
           --If Device-TLB flush is timeout, we'll hide the target ATS device 
and crash the domain owning this ATS device.
             If impacted domain is hardware domain, just throw out a warning, 
instead of crash the hardware domain.
            The hided Device will be disallowed to be further assigned to any 
domain.

Kevin, correct me if I am wrong.


Quan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel