[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 1/2] libxc: Don't write terminating NULL character to command string
On Thu, 2016-01-07 at 11:19 +0000, Wei Liu wrote: > On Wed, Jan 06, 2016 at 03:03:21PM -0500, Boris Ostrovsky wrote: > > When copying boot command string for HVMlite guests we explicitly write > > '\0' at MAX_GUEST_CMDLINE offset. Unless the string is close to > > MAX_GUEST_CMDLINE in length this write will end up in the wrong place, > > beyond the end of the mapped range. > > > > We don't need to limit the size of command string to some arbitrary > > number. Any size that can be successfully allocated and mapped is valid > > and so the string is guaranteed to be NULL-terminated (since we use > > strlen, which needs terminating '\0', to calculate allocation size). > > > > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> > > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx> Applied. Roger commented on #2 so I didn't take that, but this seemed to standalone. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |