Re: [Xen-devel] [PATCH v3 4/4] libxc: set flag for support of linear p2m list in domain builder

[Juergen Gross <jgross@xxxxxxxx>]

On 06/01/16 17:05, Ian Campbell wrote:
> On Wed, 2015-12-16 at 10:24 +0100, Juergen Gross wrote:
>> Set the SIF_VIRT_P2M_4TOOLS flag for pv-domUs in the domain builder
>> to indicate the Xen tools have full support for the virtual mapped
>> linear p2m list.
>>
>> This will enable pv-domUs to drop support of the 3 level p2m tree
>> and use the linear list only. Without setting this flag some kernels
>> might limit themselves to 512 GB memory size in order not to break
>> migration.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> I would have applied all 4 on the basis of Andy's other Reviewed-by to the
> patches purely touching migration v2 files, except for this on 32-bit:

Ouch. Will correct.


Juergen

> 
> xc_sr_save_x86_pv.c:328:9: error: format â%lxâ expects argument of type âlong 
> unsigned intâ, but argument 4 has type âuint64_tâ [-Werror=format=]
>          ERROR("Bad p2m_cr3 value %#lx", p2m_cr3);
>          ^
> xc_sr_save_x86_pv.c:350:13: error: format â%lxâ expects argument of type 
> âlong unsigned intâ, but argument 4 has type âxen_vaddr_tâ [-Werror=format=]
>              ERROR("Bad virtual p2m address range %#lx-%#lx",
>              ^
> xc_sr_save_x86_pv.c:350:13: error: format â%lxâ expects argument of type 
> âlong unsigned intâ, but argument 5 has type âxen_vaddr_tâ [-Werror=format=]
> xc_sr_save_x86_pv.c:363:13: error: format â%lxâ expects argument of type 
> âlong unsigned intâ, but argument 4 has type âxen_vaddr_tâ [-Werror=format=]
>              ERROR("Bad virtual p2m address range %#lx-%#lx",
>              ^
> xc_sr_save_x86_pv.c:363:13: error: format â%lxâ expects argument of type 
> âlong unsigned intâ, but argument 5 has type âxen_vaddr_tâ [-Werror=format=]
> xc_sr_save_x86_pv.c:370:5: error: format â%lxâ expects argument of type âlong 
> unsigned intâ, but argument 6 has type âxen_vaddr_tâ [-Werror=format=]
>      DPRINTF("p2m list from %#lx to %#lx, root at %#lx", p2m_vaddr, p2m_end,
>      ^
> xc_sr_save_x86_pv.c:370:5: error: format â%lxâ expects argument of type âlong 
> unsigned intâ, but argument 7 has type âxen_vaddr_tâ [-Werror=format=]
> xc_sr_save_x86_pv.c:413:17: error: format â%lxâ expects argument of type 
> âlong unsigned intâ, but argument 5 has type âlong long unsigned intâ 
> [-Werror=format=]
>                  ERROR("Bad mfn %#lx during page table walk for vaddr %#lx at 
> level %d of p2m list",
>                  ^
> cc1: all warnings being treated as errors
> /local/scratch/ianc/devel/committer-i686.git/tools/libxc/../../tools/Rules.mk:163:
>  recipe for target 'xc_sr_save_x86_pv.o' failed
> 
>> @@ -1,5 +1,5 @@
>>  % Migration
>> -% Revision 1
>> +% Revision 2
> 
> Well done on this, I predict it will get forgotten more often than not ;-)
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel