[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 04/13] xenstore: move init-xenstore-domain to tools/helpers
On 06/01/16 17:03, Ian Campbell wrote: > On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote: >> The program init-xenstore-domain to start a xenstore domain instead >> of the xenstored daemon is built, but not installed. Change that. >> >> Move the program to a new tools subdirectory "helpers" to be able to >> use libxl in a later patch. Otherwise a dependency loop will be >> created. >> >> While moving modify the coding style to the standard style used in >> the tools directory. > > Please don't combine such things with moving the whole file. Or at the very > least please use git send-email/format-patch -M (ideally both do it > separately and use -M). Okay, I'll do the move in this patch only. > So long as the file is self consistent I'm not convinced it is actually > worth changing, plus it doesn't actually seem to be following CODING_STYLE > (which is the default style for tools/* as well as xen/*), since hasn't > gained e.g. spaces inside of the if ( x ). As there are substantial changes to this file in later patches, I'll do the coding style changes in a separate patch, using the _correct_ style. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |