[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 5/5] tools/libxl: remove unused function libxl__domain_save_device_model()
å 2016/1/6 22:10, Wei Liu åé: On Tue, Jan 05, 2016 at 10:06:21AM +0800, Wen Congyang wrote:After the commit d77570e7, libxl__domain_save_device_model() can be dropped. Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>This is incomplete as far as I can tell. There are several references to the said function: $ git grep libxl__domain_save_device_model libxl.c: * On suspend libxl__domain_save_device_model will have already libxl__domain_save_device_model() will remove the dm_savefile. But we don't remove it when using migration v2. libxl_dom.c:void libxl__domain_save_device_model(libxl__egc *egc, libxl_internal.h: /* private for libxl__domain_save_device_model */ libxl_internal.h:_hidden void libxl__domain_save_device_model(libxl__egc *egc, I think you haven't handled the instances showed up in line 1 and line 3. Yes, I will fix it in the next version. Thanks Wen Congyang Wei. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |