Re: [Xen-devel] [PATCH v2 01/13] xen: add xenstore domain flag to hypervisor

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote:
> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> index 3fc3824..6304eb9 100644
> --- a/xen/include/xsm/xsm.h
> +++ b/xen/include/xsm/xsm.h
> @@ -35,6 +35,7 @@ enum xsm_default {
> ÂÂÂÂÂXSM_DM_PRIV,ÂÂ/* Device model can perform on its target domain */
> ÂÂÂÂÂXSM_TARGET,ÂÂÂ/* Can perform on self or your target domain */
> ÂÂÂÂÂXSM_PRIV,ÂÂÂÂÂ/* Privileged - normally restricted to dom0 */
> +ÂÂÂÂXSM_XS_PRIV,ÂÂ/* Xenstore domain can obtain domain info */

Nit: This is conflating the semantic meaning of this bit with what the
implementation happens to be in practice right now.

I'd say something more like "Privileged or operations allowed to a xenstore
domain" perhaps.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel