[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [xen-4.4-testing test] 66583: regressions - FAIL
On Tue, 2015-12-22 at 14:40 +0000, Stefano Stabellini wrote: > On Tue, 22 Dec 2015, Jan Beulich wrote: > > > > > On 22.12.15 at 14:55, <stefano.stabellini@xxxxxxxxxxxxx> wrote: > > > On Mon, 21 Dec 2015, Jan Beulich wrote: > > > > > > > On 20.12.15 at 13:25, <osstest-admin@xxxxxxxxxxxxxx> wrote: > > > > > flight 66583 xen-4.4-testing real [real] > > > > > http://logs.test-lab.xenproject.org/osstest/logs/66583/ > > > > > > > > > > Regressions :-( > > > > > > > > > > Tests which did not succeed and are blocking, > > > > > including tests which could not be run: > > > > > Âbuild-amd64-prevÂÂÂÂÂÂÂÂÂÂÂÂÂÂ5 xen-buildÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfail > > > > > REGR. vs. > > > 66458 > > > > > Âbuild-i386-prevÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ5 xen-buildÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfail > > > > > REGR. vs. > > > 66458 > > > > > > > > Ian, Stefano, > > > > > > > > is one of you two looking into this? > > > > > > > > block-qcow.c: In function 'get_cluster_offset': > > > > block-qcow.c:444:3: error: 'tmp_ptr' may be used uninitialized in > > > > this > > > function [-Werror=maybe-uninitialized] > > > > ÂÂÂmemcpy(tmp_ptr, l1_ptr, 4096); > > > > ÂÂÂ^ > > > > block-qcow.c:619:7: error: 'tmp_ptr2' may be used uninitialized in > > > > this > > > function [-Werror=maybe-uninitialized] > > > > ÂÂÂif (write(s->fd, tmp_ptr2, 4096) != 4096) { > > > > ÂÂÂÂÂÂÂ^ > > > > cc1: all warnings being treated as errors > > > > > > > /home/osstest/build.66583.build-amd64- > > > prev/xen/tools/blktap/drivers/../../../to > > > ols/Rules.mk:89: recipe for target 'block-qcow.o' failed > > > > make[5]: *** [block-qcow.o] Error 1 > > > > > > What does build-amd64-prev means? I cannot find the explanation of > > > the > > > test anywhere. > > > > Iiuc it's the build pf the previous version, needed to test n-1 -> n > > migration. I.e. (in line with the respective 4.3 failure) it indicates > > that 4.3's qemu doesn't build. > > Thanks for the explanation, it was very helpful. > > From the logs what is not building is actually tools/blktap, not QEMU > though, but I cannot reproduce the failure. I think we want to backport: commit 345e44a85d71a1a910385f33c7f1ba3683026d18 Author: Dario Faggioli <dario.faggioli@xxxxxxxxxx> Date:ÂÂÂFri Jun 20 16:09:00 2014 +0200 ÂÂÂÂblktap2: Fix two 'maybe uninitialized' variables ÂÂÂÂ ÂÂÂÂfor which gcc 4.9.0 complains about, like this: ÂÂÂÂ ÂÂÂÂblock-qcow.c: In function `get_cluster_offset': ÂÂÂÂblock-qcow.c:431:3: error: `tmp_ptr' may be used uninitialized in this function ÂÂÂÂ[-Werror=maybe-uninitialized] ÂÂÂÂÂÂÂmemcpy(tmp_ptr, l1_ptr, 4096); ÂÂÂÂÂÂÂ^ ÂÂÂÂblock-qcow.c:606:7: error: `tmp_ptr2' may be used uninitialized in this ÂÂÂÂfunction [-Werror=maybe-uninitialized] ÂÂÂÂÂÂÂif (write(s->fd, tmp_ptr2, 4096) != 4096) { ÂÂÂÂÂÂÂÂÂÂÂ^ ÂÂÂÂcc1: all warnings being treated as errors ÂÂÂÂ /home/dario/Sources/xen/xen/xen.git/tools/blktap2/drivers/../../../tools/Rules.mk:89: ÂÂÂÂÂrecipe for target 'block-qcow.o' failed ÂÂÂÂmake[5]: *** [block-qcow.o] Error 1 ÂÂÂÂ ÂÂÂÂThe proper behavior is to return upon allocation failure. ÂÂÂÂAbout what to return, 0 seems the best option, looking ÂÂÂÂat both the function and the call sites. ÂÂÂÂ ÂÂÂÂSigned-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx> ÂÂÂÂAcked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> (this will have been exposed by the update to Jessie's compiler) _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |