[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH] svm: rephrase local variable use for Coverity.
Coverity CID 1343310 No functional changes. Signed-off-by: Joshua Otto <jtotto@xxxxxxxxxxxx> --- On Mon, Dec 28, 2015 at 09:34:28AM +0000, Andrew Cooper wrote: > The error message isn't fantastic, but the complaint that Coverity > has is that we store intr here, then unilaterally store it again > slightly lower in the function, no matter what value it had (with > the early return presumably not being taken into account). > > The error would probably be resolved if lines 95 and 96 turned into > "if ( vmcb_get_vintr(gvmcb).fields.irq )" This patch implements that change - as a general rule, is maintainer preference to resolve false positives like this by suppressing them in the tool or through code changes like this one? xen/arch/x86/hvm/svm/intr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index bd94731..240eb35 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -92,8 +92,7 @@ static void svm_enable_intr_window(struct vcpu *v, struct hvm_intack intack) * return here or l2 guest looses interrupts, otherwise. */ ASSERT(gvmcb != NULL); - intr = vmcb_get_vintr(gvmcb); - if ( intr.fields.irq ) + if ( vmcb_get_vintr(gvmcb).fields.irq ) return; } } -- 1.9.1 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |