Re: [Xen-devel] [PATCH 3/5] tools/libxc: don't send end record if remus fails

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 30/12/2015 01:39, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

While looking at this code, what about error handling for the postcopy() 
callback just out of context?
> ---
>   tools/libxc/xc_sr_save.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
> index cefcef5..76ebb34 100644
> --- a/tools/libxc/xc_sr_save.c
> +++ b/tools/libxc/xc_sr_save.c
> @@ -790,7 +790,7 @@ static int save(struct xc_sr_context *ctx, uint16_t 
> guest_type)
>   
>               rc = ctx->save.callbacks->checkpoint(ctx->save.callbacks->data);
>               if ( rc <= 0 )
> -                ctx->save.checkpointed = false;
> +                goto err;
>           }
>       } while ( ctx->save.checkpointed );
>   

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel