[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] patch about "don't reset vcpu_info on a cancelled suspend"



Hi David,

This patch has been applied to for-linus-4.1b, and we wonder if this patch will 
be applied to linux kernel, or does
it still needs more test to apply to linux kernel?

thanks

On 2015.5.28 19:07, David Vrabel wrote:
>> vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM 
>> which has multi-cpu
>>
>> The hypervisor continues assuming that vcpu_info is stored in per-cpu data 
>> which was set up by xen_vcpu_setup(),
>> while on canceled suspend, the call to xen_hvm_init_shared_info() will make 
>> the guest think that vcpu_info
>> is in the shared page. This will cause non-boot cpus keep checking a wrong 
>> vcpu_info address and can not handle
>> irqs any more after suspend canceled, for example after we do "xl save 
>> -c/restore", PVOPS VM can not be resumed
>> as the cpus can not finish their irqs.
>>
>>
>> Signed-off-by: Charles Ouyang <ouyangzhaowei [at] huawei>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky [at] oracle>
>> Reviewed-by: David Vrabel <david.vrabel [at] citrix>
>
> 1. I don't think I offered a reviewed-by tag for this patch
> 2. You did not Cc the xen-devel mailing list on this patch.
> 3. The patch is white-space damaged.
> 4. The commit message has lines longer than ~72 chars.
>
> But I've applied this to for-linus-4.1b anyway, thanks.
>
> David


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.