Re: [Xen-devel] [PATCH v2 2/2] x86/PCI: Intercept Dom0 MMCFG from dom0s in HVM containers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.12.15 at 21:22, <boris.ostrovsky@xxxxxxxxxx> wrote:
> Commit 9256f66c1606 ("x86/PCI: intercept all PV Dom0 MMCFG writes")
> added intercepts for writes to RO MMCFG space from PV dom0.
> 
> Similar functionality is needed by dom0s in HVM containers (such as
> PVH and, in the future, HVMlite).
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

Looks okay leaving aside the question of r/o device handling. A few
minor remarks:

> @@ -463,4 +466,14 @@ void *
>  decode_register(
>      uint8_t modrm_reg, struct cpu_user_regs *regs, int highbyte_regs);
>  
> +/* Unhadleable read, write or instruction fetch */

Unhandleable

> +int
> +unhandleable_rwx(

x86emul_unhandleable_rwx() or some such, making it clear what
component it belongs to. I also doubt the x here really makes much
sense - the insn_fetch field can't usefully point to that function.

> +    enum x86_segment seg,
> +    unsigned long offset,
> +    void *p_data,
> +    unsigned int bytes,
> +    struct x86_emulate_ctxt *ctxt);
> +
> +
>  #endif /* __X86_EMULATE_H__ */

One blank line only please.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel