Re: [Xen-devel] [OSSTEST PATCH 6/9] db_retry: Suppress an "exiting via last" warning

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-12-17 at 17:06 +0000, Ian Jackson wrote:
> This warning appears when db_retry_abort is used, since 2b069b6c
> "Database locking: Perl: Retry all deadlocks in PostgreSQL".

Is the reason for not turning this into a return related to the fact this
is within an eval, not a proper sub? But then I'm not really sure why it is
warning (I suppose eval has some sub like properties?).

Related toÂhttps://rt.perl.org/Public/Bug/Display.html?id=29238Âperhaps.

> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
> ÂOsstest.pm |ÂÂÂÂ1 +
> Â1 file changed, 1 insertion(+)
> 
> diff --git a/Osstest.pm b/Osstest.pm
> index c77d960..a398b1e 100644
> --- a/Osstest.pm
> +++ b/Osstest.pm
> @@ -299,6 +299,7 @@ sub db_retry ($$$;$$) {
> Â     ÂÂÂÂ$r= &$body;
> Â     ÂÂÂÂif ($db_retry_stop) {
> Â             $dbh->rollback();
> +             no warnings qw(exiting);
> Â             last if $db_retry_stop eq 'abort';
> Â             next;
> Â     ÂÂÂÂ}

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel