Re: [Xen-devel] [PATCH v3 6/6] xl: Return error code on save

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 01/12/15 11:53, George Dunlap wrote:
> save_domain was already constructing an error code; it just wasn't
> being used.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> ---
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  tools/libxl/xl_cmdimpl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 5f21c37..52aedcf 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -4712,8 +4712,7 @@ int main_save(int argc, char **argv)
>      if ( argc - optind >= 3 )
>          config_filename = argv[optind + 2];
>  
> -    save_domain(domid, filename, checkpoint, leavepaused, config_filename);
> -    return 0;
> +    return save_domain(domid, filename, checkpoint, leavepaused, 
> config_filename);

Ah -- turns out the reason the return value "wasn't being used" was that
save_domain() actually calls exit() itself directly.

I'll drop this patch, as the headline feature (xl failing on the save
failing) appears to be working properly.  Maybe we can put this on a
list of clean-up items.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel