Re: [Xen-devel] [PATCH] x86: Make debug output consistent in hvm_set_callback_via

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.12.15 at 17:10, <malcolm.crossley@xxxxxxxxxx> wrote:
> The unconditional printks in the switch statement of the
> hvm_set_callback_via function results in Xen log spam in non debug
> versions of Xen.

Oh, now I see - that's because dprintk() is a no-op inline nowadays.

> --- a/xen/arch/x86/hvm/irq.c
> +++ b/xen/arch/x86/hvm/irq.c
> @@ -386,7 +386,8 @@ void hvm_set_callback_via(struct domain *d, uint64_t via)
>  
>      spin_unlock(&d->arch.hvm_domain.irq_lock);
>  
> -    dprintk(XENLOG_G_INFO, "Dom%u callback via changed to ", d->domain_id);
> +#ifndef NDEBUG
> +    printk(XENLOG_G_INFO, "Dom%u callback via changed to ", d->domain_id);

This won't compile without warnings due to the extra comma.

The right solution here seems to be to clone Linux'es "continue"
log level, and then make dprintk() avoid adding its prefix in that
case.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel