[Xen-devel] [Minios-devel] [PATCH v7 0/<VARIOUS>] Begin to disentangle libxenctrl and provide some stable libraries

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

In <1431963008.4944.80.camel@xxxxxxxxxx> I proposed stabilising some
parts of the libxenctrl API/ABI by disaggregating into separate
libraries.

This is v7 of that set of series against:
ÂÂÂÂxen
ÂÂÂÂqemu-xen
ÂÂÂÂqemu-xen-traditional
ÂÂÂÂmini-os

NB: Samuel+minios-devel will only get the mini-os side and Stefano+qemu
-devel the qemu-xen side.

The code for all repos can be found in:

git://xenbits.xen.org/people/ianc/libxenctrl-split/xen.gitÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂv7
git://xenbits.xen.org/people/ianc/libxenctrl-split/qemu-xen.gitÂÂÂÂÂÂÂÂÂÂÂÂÂv7
git://xenbits.xen.org/people/ianc/libxenctrl-split/qemu-xen-traditional.git v7
git://xenbits.xen.org/people/ianc/libxenctrl-split/mini-os.gitÂÂÂÂÂÂÂÂÂÂÂÂÂÂv7

The tip of the xen.git branch contains an extra patch hacking Config.mk
to point to all the others above, which should get the correct things for
the HEAD of the branch, but not further back in time.

The new libraries here are:

Â* libxentoollog: Common logging infrastructure
Â* libxenevtchn: Userspace access to evtchns (via /dev/xen/evtchn etc)
Â* libxengnttab: Userspace access to grant tables (via /dev/xen/gnt??? etc)
Â* libxencall: Making hypercalls (i.e. the IOCTL_PRIVCMD_HYPERCALL type
ÂÂÂfunctionality)
Â* libxenforeignmemory: Privileged mappings of foreign memory
ÂÂÂ(IOCTL_PRIVCMD_MMAP et al)

The first three were actually pretty distinct within libxenctrl already and
have not changed in quite some time.

Although the other two are somewhat new they are based on top of long
standing stable ioctls, which gives me some confidence.

Nonetheless I would appreciate extra review of at least the interface
headers of all of these with a particular eye to the suitability of these
interfaces being maintained in an ABI (_B_, not _P_) stable way going
forward.

Still to come would be libraries for specific out of tree purposes
(device model, kexec), which would be adding new library at the same
level as libxc I think, rather than underneath, i.e. also using the
libraries split out here, but hopefully not libxenctrl itself.

The new libraries use linker version-scripts to hopefully make future
ABI changes be possible in a compatible way.

Since last time:

 * Lots more docs updates based on feedback given and especially the
   discussion around the semantics of the libraries wrt forking without
   exec.
 * s/gnttab_munmap/gnttab_unmap/ and s/gntshr_munmap/gntshr_unshare/ Â Â Â
   Âin the libxengnttab API.
 * Use O_CLOEXEC on Linux and FreeBSD unconditionally.
 * Fixed a stubdom/Makefile build race issue
 * Dropped -pedantic from headers check, the headers in xen/include/public
   are not -pedantic clean, and the libraries can include headers from
   there (and then the check breaks).
 * Dropped libxencall atform madvise thing, in favour of simpler solution
   of touching the pages to uncow them.
 * The xentoollog patch went in but was reverted, that patch now refers to
   the revisions of qemu and mini-os with the corresponding changes.

Even with the dropped acks mini-os and qemu-xen-trad are fully acked, while
qemu-xen and xen are mostly acked (but had a few dropped acks since last
time).

The whole thing has been build tested on Linux (incl stubdoms), and on
FreeBSD. I have runtime tested on Linux with qemu-xen, qemu-xen-trad and
stubdoms.

Neither NetBSD nor Solaris have been tested at all. It's certainly not
impossible that I've not got the #includes in the new files quite right.

http://xenbits.xen.org/people/ianc/libxenctrl-split/v7.html is the document
I've been using to try and track what I'm doing. It may not be all that
useful. The history of it is in the v6-with-doc branch of the xen.git
linked to above.

A few of the initial patches went in, but in the meantime I discovered a
wrinkle in the changes to the stubdom build changes, so now there are some
new ones.

  tools: Refactor "xentoollog" into its own library

went in but then came out again and is now blocking on a libvirt patch,
which is in libvirt.git#master waiting to get through our libvirt push
gate.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel