Re: [Xen-devel] [PATCH] x86: generate labels at the beginning of unlikely sub-sections

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/12/15 13:42, Jan Beulich wrote:
> This is to limit symbol table growth, which would be quite a bit worse
> if we went with the "label every unlikely sub-section contribution"
> approach proposed previously.
>
> Older gas doesn't support quoted symbols, yet the result looks quite
> bit better that way. Hence two variants get introduced, one using
> proper path names (including slashes and dashes) and one using path
> names after converting them to valid symbol names (slashes and dashes
> replaced).
>
> As a secondary adjustment also change the section name used with Clang.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

(XEN) '1' pressed -> Extreme debugging in progress...
(XEN) Xen WARN at /local/xen.git/xen/include/asm/hvm/vmx/vmx.h:329
(XEN) ----[ Xen-4.7-unstable  x86_64  debug=y  Not tainted ]----
(XEN) CPU:    0
(XEN) RIP:    e008:[<ffff82d08019c2f2>]
traps.c#arch/x86/traps.o.unlikely+0/0x8
<snip>
(XEN) Xen call trace:
(XEN)    [<ffff82d08019c2f2>] traps.c#arch/x86/traps.o.unlikely+0/0x8
(XEN)    [<ffff82d080114bd3>] handle_keypress+0xa4/0xd9
(XEN)    [<ffff82d08014282c>] console.c#__serial_rx+0x16/0x51
(XEN)    [<ffff82d080142fb7>] console.c#serial_rx+0x8a/0x8f
(XEN)    [<ffff82d08014529f>] serial_rx_interrupt+0x90/0xac
(XEN)    [<ffff82d080143cef>] ns16550.c#ns16550_interrupt+0x57/0x71
(XEN)    [<ffff82d08016fffe>] do_IRQ+0x582/0x629
(XEN)    [<ffff82d08023dea2>] common_interrupt+0x62/0x70
(XEN)

Looks good.

Reviewed-by: Andrew Cooper <andrew.cooper@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel