Re: [Xen-devel] [PATCH XEN v6 22/32] tools/libs/foreignmemory: optimise map(num==1, err==NULL) case

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-12-09 at 15:42 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH XEN v6 22/32] tools/libs/foreignmemory:
> optimise map(num==1, err==NULL) case"):
> > This looks to be a reasonably common case (many of the previous
> > callers to xc_map_foreign_pages use it) and it is easy enough to avoid
> > a malloc for it.
> ...
> > I'm not 100% sure this is worth the complexity, hence not folding
> > into the base patch yet, it could easily be dropped.
> 
> I would suggest that we should park this until we have a benchmark
> showing it's helpful.

Agreed, dropped for v7.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel