Re: [Xen-devel] [OSSTEST PATCH 4/7] Schema: Introduce mg-schema-create

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 4/7] Schema: Introduce 
mg-schema-create"):
> On Thu, 2015-12-10 at 13:51 +0000, Ian Jackson wrote:
> > There is a fair amount of option parsing clobber here that will be
> > relevant shortly.
> 
> How dangerous is this script if you just run it e.g. without with_test?

Not particularly:

(osstest)mariner:testing.git> 
OSSTEST_CONFIG=/u/iwj/.xen-osstest/config:local-config.test-database_iwj 
./mg-schema-create
Populating database...
SET
SET
SET
SET
SET
SET
SET
SET
SET
psql:schema/initial.sql:28: ERROR:  relation "flights" already exists
(osstest)mariner:testing.git> 

> Specifically, would it nuke an existing database?

So, no.  If we ever delete the `flights' table in a schema update,
this script might recreate it before falling over later.  So if we do
that we ought to add a safety catch to mg-schema-create, for example
to have it check that no schema updates have yet been applied.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel