Re: [Xen-devel] [PATCH v2] libxl: update check-xl-disk-parse

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-12-09 at 13:12 -0700, Jim Fehlig wrote:
> On 12/09/2015 03:43 AM, Wei Liu wrote:
> > The block-attach command now returns 1 when fails. Update first test
> > case to expect return value 1 instead of 255.
> > 
> > The parser now doesn't generate output for default values. Remove them
> > from expected output.
> 
> I made the same changes yesterday to get the tests to pass.
> 
> > According to 417e6b70 ("libxl: add option for discard support to xl
> > disk
> > configuration"), the "discard=" variant is never supported, delete two
> > test cases with that variant.
> 
> Heh, I didn't realize "discard=" wasn't supported and instead added
> support for 
> parsing it in libxlu_disk_l.l :-)
> 
> Looks good to me.
> 
> ÂÂÂÂÂTested-by: Jim Fehlig <jfehlig@xxxxxxxx>

Acked + applied.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel