Re: [Xen-devel] [PATCHv6] 03/28] build: use generated Kconfig options for Xen

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.12.15 at 21:34, <cardoe@xxxxxxxxxx> wrote:
> On 12/9/15 2:40 AM, Jan Beulich wrote:
>>>>> On 08.12.15 at 20:53, <cardoe@xxxxxxxxxx> wrote:
>>> On 11/30/15 8:45 AM, Jan Beulich wrote:
>>>>>>> On 24.11.15 at 18:51, <cardoe@xxxxxxxxxx> wrote:
>>>>> @@ -227,9 +230,14 @@ kconfig := silentoldconfig oldconfig config 
>>>>> menuconfig defconfig \
>>>>>  $(kconfig):
>>>>>   $(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=$(XEN_TARGET_ARCH) 
>>>>> $@
>>>>>  
>>>>> -$(BASEDIR)/include/config/%.conf: $(BASEDIR)/include/config/auto.conf.cmd
>>>>> +$(BASEDIR)/include/config/%.conf: 
>>>>> $(BASEDIR)/include/config/auto.conf.cmd $(BASEDIR)/.config
>>>>>   $(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile 
>>>>> ARCH=$(XEN_TARGET_ARCH) silentoldconfig
>>>>>  
>>>>>  # Allow people to just run `make` as before and not force them to 
>>>>> configure
>>>>> -$(BASEDIR)/.config $(BASEDIR)/include/config/auto.conf.cmd: ;
>>>>> +$(BASEDIR)/.config:
>>>>>   $(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile 
>>>>> ARCH=$(XEN_TARGET_ARCH) defconfig
>>>>
>>>> This should be one of the oldconfig targets now, shouldn't it?
>>>
>>> oldconfig uses .config. This is the case when the user has checked out
>>> the tree fresh. Its there to not change the workflow of "git clone ...
>>> && cd xen/xen && make"
>> 
>> Okay. But then this is meant to only support the simplest possible
>> form, i.e. without honoring any make command line or ./.config
>> overrides like debug=y or kexec=n? If that understanding of
>> mine is correct, at least the comment should mention such a
>> limitation (even better would be if in such cases unexpected
>> results would be prevented by - as the most trivial solution -
>> failing the build with a meaningful error message).
> 
> So you would like me to add code into xen/Makefile to detect if someone
> ran "make kexec=X" or added "kexec=X" into top level .config and give
> them a meaningful error message to tell them to use "make config" instead?

If you want to do the "(even better ...)" form, yes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel