Re: [Xen-devel] [PATCH] libxl: update check-xl-disk-parse

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Dec 09, 2015 at 10:15:35AM +0000, Wei Liu wrote:
> On Wed, Dec 09, 2015 at 10:06:17AM +0000, Ian Campbell wrote:
> > On Tue, 2015-12-08 at 20:02 +0000, Wei Liu wrote:
> > > The block-attach command now returns 1 when fails. Update first test
> > > case to expect return value 1 instead of 255.
> > > 
> > > The parser now doesn't generate output for default values. Remove them
> > > from expected output.
> > 
> > This it looks good.
> > 
> > > The "discard=" variant is never not supported, so delete two test cases
> > > with that variant.
> > 
> > I don't follow (the double negative "never not" doesn't help).
> > 
> 
> Duh, I didn't intend to use double negation.
> 
> > However, assuming you are saying that discard= is always supported, I don't
> > then see the rationale for removing the test. Of course we do want to test
> > things which are supported.
> > 
> 
> No, it is not supported. I dug into mailing list archive last night and
> confirmed that Ian J asked Olaf to remove such variant. Those test cases
> were residual from a previous version Olaf failed to remove.
> 

Forgot to paste in the references:

commit 417e6b70d73ffe8f8d3938aa30a413b35098e614 in xen.git

http://lists.xen.org/archives/html/xen-devel/2014-05/msg01063.html

> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel