Re: [Xen-devel] [OSSTEST PATCH 11/11] mg-schema-test-database: Sort out daemons; provide `daemons' subcommand

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 11/11] mg-schema-test-database: Sort 
out daemons; provide `daemons' subcommand"):
> On Fri, 2015-12-04 at 19:35 +0000, Ian Jackson wrote:
> > We arrange for the test configuration to look for the daemons on a
> > different host and port, and we provide a convenient way to run such a
> > pair of daemons.
> 
> I was missing where *Daemon{Host,Port} were set here, it turns out to be in
> patch 9, which might be a bisection issue? I'm not sure we care for this
> new code.

Indeed that hunk is misplaced.

> It also occurred to me while reading this that I didn't know what to do
> with OSSTEST_CONFIG here, I've not spotted in patch 9 where withtest()
> behaves in the obvious way, but it might be worth mentioning explicitly in
> the comments that the script DTRT and it is never(/rarely) necessary to set
> OSSTEST_CONFIG=local-config.test-database_SUFFIX yourself.

After you have run mg-schema-test-database create, you want to set
OSSTEST_CONFIG somehow.  Otherwise everything still runs against the
original database.

I do have a patch (unposted, because I thought better of it) to make
the config file reader automatically find and slurp any files called
local-config.something, after (and thus overriding OSSTEST_CONFIG0.
Do you think that would be a good idea ?  It seems a bit hairy to me.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel