[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 06/62] acpi: Refactor acpi_os_map_memory to be architecturally independent

To: <shannon.zhao@xxxxxxxxxx>, <ian.campbell@xxxxxxxxxx>, <stefano.stabellini@xxxxxxxxxx>, <keir@xxxxxxx>, <jbeulich@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxx>
From: Julien Grall <julien.grall@xxxxxxxxxx>
Date: Mon, 7 Dec 2015 12:00:01 +0000
Cc: mark.rutland@xxxxxxx, hangaohuai@xxxxxxxxxx, ard.biesheuvel@xxxxxxxxxx, peter.huangpeng@xxxxxxxxxx, david.vrabel@xxxxxxxxxx, zhaoshenglong@xxxxxxxxxx, roger.pau@xxxxxxxxxx, christoffer.dall@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 07 Dec 2015 12:01:31 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

Hi Shannon,

On 17/11/15 09:40, shannon.zhao@xxxxxxxxxx wrote:
> From: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> 
> Current acpi_os_map_memory is specific to x86. Refactor it to be
> architecturally independent.

The function acpi_os_unmap_memory should also be arch-independent.

Otherwise, with the implementation you did on ARM (see patch #7), you
will destroy by mistake the mapping in the page table for those regions.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Prev by Date: [Xen-devel] blkback feature announcement
Next by Date: Re: [Xen-devel] [PATCH v3 07/62] arm/acpi: Add arch_acpi_os_map_memory helper function for ARM
Previous by thread: [Xen-devel] blkback feature announcement
Next by thread: [Xen-devel] Patch "x86/cpu: Fix SMAP check in PVOPS environments" has been added to the 4.1-stable tree
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.