Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 12/04/2015 10:24 AM, David Vrabel wrote:
> On 04/12/15 14:06, David Vrabel wrote:
> > On 03/12/15 10:43, David Vrabel wrote:
> > > Adding the rtc platform device when there are no legacy irqs (no
> > > legacy PIC) causes a conflict with other devices that end up using the
> > > same irq number.
> > An alternative is to remove the rtc_cmos platform device in Xen PV
> > guests.
> >
> > Any preference on how this regression should be fixed?
> >
> > David
> >
> > 8<--------------------------
> > x86: Xen PV guests don't have the rtc_cmos platform device
> [...]
> > --- a/arch/x86/kernel/rtc.c
> > +++ b/arch/x86/kernel/rtc.c
> > @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void)
> >         }
> >   #endif
> >   
> > +	if (xen_pv_domain())
> > +               return -ENODEV;
> > +
> Note there's a missing include that breaks !XEN builds.
We could also use paravirt_enable() here which will probably cover 
HVMlite case as well. (Until we start turning on and off various HVMlite 
features).
Don't know how it will affect lguest (which so far is the only other 
paravirt-enabled guest).
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel