Re: [Xen-devel] [V2 PATCH 8/9] x86/hvm: pkeys, add xstate support for pkeys

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 03/12/15 01:58, Han, Huaitong wrote:
> On Wed, 2015-12-02 at 04:31 -0700, Jan Beulich wrote:
>>>>> On 02.12.15 at 08:20, <huaitong.han@xxxxxxxxx> wrote:
>>>> Does this even compile?  There is already
>>>>
>>>> static void *get_xsave_addr(void *xsave, unsigned int
>>>> xfeature_idx)
>>>>
>>>> higher in the same file.
>>>>
>>>> That function should be augmented to take a struct xsave_struct
>>>> *xsave,
>>>> look at whether the representation is compressed or not, and use
>>>> the
>>>> appropriate offset array.
>>>>
>>> Just because I have pulled staging branch when "static void
>>> *get_xsave_addr(void *xsave, unsigned int xfeature_idx)" is not
>>> added.
>> Yet you use the function on patch 7 already...
> The function used by patch 7 has same name but is added by me.

You must ensure that your patch series compiles and functions correctly
at each patch boundary.  This is for bisectability.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel