Re: [Xen-devel] [PATCH v2] build: fix clean to remove all .o and .d files

[Jonathan Creekmore <jonathan.creekmore@xxxxxxxxx>]

> On Dec 2, 2015, at 9:36 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> 
>>>> On 02.12.15 at 16:29, <jonathan.creekmore@xxxxxxxxx> wrote:
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -91,7 +91,8 @@ _clean: delete-unfresh-files
>>      $(MAKE) -f $(BASEDIR)/Rules.mk -C xsm clean
>>      $(MAKE) -f $(BASEDIR)/Rules.mk -C crypto clean
>>      $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) clean
>> -    rm -f include/asm *.o $(TARGET) $(TARGET).gz $(TARGET).efi 
>> $(TARGET)-syms *~ core $(DEPS)
>> +    find . \( -name "*.o" -o -name "*.d" \) -exec rm -f {} \;
> 
> If you really meant *.d, then *.[od] would have done. But in fact I
> think we want to limit this to ".*.d". Which I could fix up while
> committing, but then I'm not sure â

Easy enough to change it to â.*.dâ.

> 
>> --- a/xen/Rules.mk
>> +++ b/xen/Rules.mk
>> @@ -173,7 +173,7 @@ FORCE:
>> 
>> .PHONY: clean
>> clean:: $(addprefix _clean_, $(subdir-all))
>> -    rm -f *.o *~ core $(DEPS)
>> +    rm -f *~ core
> 
> ... this is a good idea, as it's not clear to me whether "clean" actually
> works when invoked in sub-trees of xen/.

I can definitely take that bit out; I just didnât see the point in replicating 
the
removal of the files. Note that, whether I take it out or leave it in, âcleanâ 
still
will not totally work when invoked in sub-trees of xen/ because *.o is still not
enough to catch all of the object files (which was the whole point of this patch
in the first place).
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel