[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory
>>> On 30.11.15 at 17:31, <jonathan@xxxxxxxxxxxxxxxxx> wrote: > On Wed, Nov 25, 2015 at 10:16 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote: >> The use of $(basename ...) here was wrong (yet I'm sure I tested it). >> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> >> >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -105,7 +105,7 @@ include Makefile >> DEPS = .*.d >> define gendep >> ifneq ($(1),$(subst /,:,$(1))) >> - DEPS += $(dir $(1)).$(basename $(notdir $(1))).d >> + DEPS += $(dir $(1)).$(notdir $(1)).d >> endif >> endef >> $(foreach o,$(filter-out %/,$(obj-y)),$(eval $(call gendep,$(o)))) > > I finally got a chance to take a look at this patch today and it does fix > the > dependency tracking for files in the xen/common/compat directory. However, > it still doesn't do anything to fix the failure to clean the object > files that are > left behind in that directory by 'make clean'. After running it, I still > have: > > $ find . -name "*.o*" > ./common/compat/kernel.o > ./common/compat/domain.o > ./common/compat/tmem_xen.o > ./common/compat/memory.o > ./common/compat/multicall.o > ./common/compat/xlat.o Oh, it wasn't even clear to me that these too are a problem. Mind contributing another patch? Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |