[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 58/62] xen/acpi: Fix event-channel interrupt when booting with ACPI



On 27/11/15 15:12, Stefano Stabellini wrote:
>> +    }
>> +    else
>> +    {
>> +        int type = 3;
>> +        int flag = 2; /* Active-low level-sensitive  */
>> +        d->arch.hvm_domain.params[HVM_PARAM_CALLBACK_IRQ] = (u64)type << 56
>> +                                                            | flag << 8
>> +                                                            | 
>> d->arch.evtchn_irq;
>> +    }
>>  }
> 
> Actually there is no point in setting HVM_PARAM_CALLBACK_IRQ only on
> ACPI: I would just set it on all cases.

+1

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.