[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCHv6] 15/28] build: convert HAS_KEXEC use to Kconfig



>>> On 24.11.15 at 18:52, <cardoe@xxxxxxxxxx> wrote:
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -68,7 +68,7 @@ ifneq ($(max_phys_irqs),)
>  CFLAGS-y                += -DMAX_PHYS_IRQS=$(max_phys_irqs)
>  endif
>  
> -CONFIG_KEXEC-$(HAS_KEXEC) := $(kexec)
> +CONFIG_KEXEC-$(CONFIG_HAS_KEXEC) := $(kexec)
>  CONFIG_KEXEC              := $(CONFIG_KEXEC-y)

This may be another exception to the "no prompts" rule, since we
already allow the feature to be turned of from the make command
line. However, you should do away with the old method then (and
the option then likely should be KEXEC, not HAS_KEXEC, since I
don't think HAS_KEXEC but !KEXEC would produce anything useful).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.