[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 01/11] xen/arm: vgic-v2: Implement correctly ICFGR{0, 1} read-only
Hi Ian, On 25/11/15 12:29, Ian Campbell wrote: > On Tue, 2015-11-24 at 17:14 +0000, Ian Campbell wrote: >> @@ -507,10 +507,12 @@ static int vgic_v2_distr_mmio_write(struct vcpu >>> *v, >>> mmio_info_t *info, >>> >>> case GICD_ICFGR: /* SGIs */ >>> goto write_ignore_32; >>> - case GICD_ICFGR + 1: /* PPIs */ >>> + >>> + case GICD_ICFGR1: >> >> This should have a /* PPIs */ comment I think? >> >> I think I could add that on commit if you agree. > > With you being away this week I decided this wasn't worth holding up 11 > patches over and committed without. Instead: FWIW, I'm fine with that as it was a mistake while I wrote the patch. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |