[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [OSSTEST PATCH] sg-run-job: Coalesce a couple of repetitions
Ian Campbell writes ("Re: [OSSTEST PATCH] sg-run-job: Coalesce a couple of repetitions"): > On Fri, 2015-11-27 at 16:54 +0000, Ian Jackson wrote: > > The resulting testid `guest-localmigrate/x10' becomes a bit misleading > > in that it now does 11 repetitions. But we don't want to change the > > testid. > > I'd be inclined to just accept the possibility of missing a failure on the > 11th iteration and just do 10 instead of 10+1. OK. > When this repeat starts the guest is now stopped, whereas before it was > running. Does the body of the loop, which starts with a ts-guest-stop, > handle that? No, oops. Clearly I should test this for real... > Maybe you should remove the ts-guest-stop right at the start of this fn > too? It's probably better to swap the order of things in the repeat, and move the extra start to below the repeat. That way if guest-stop fails utterly (which it does in several tests) it won't look like a failure of starting. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |