Re: [Xen-devel] [PATCH] x86: properly macroize the two XRSTOR flavors

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.11.15 at 14:49, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 27/11/15 11:54, Jan Beulich wrote:
>>      switch ( __builtin_expect(ptr->fpu_sse.x[FPU_WORD_SIZE_OFFSET], 8) )
>>      {
>> +#define XRSTOR(pfx) \
>> +        alternative_io("1: .byte " pfx "0x0f,0xae,0x2f\n" \
>> +                       "   .section .fixup,\"ax\"\n" \
>> +                       "2: mov %[size],%%ecx\n" \
>> +                       "   xor %[lmask_out],%[lmask_out]\n" \
>> +                       "   rep stosb\n" \
>> +                       "   lea %[mem],%[ptr]\n" \
>> +                       "   mov %[lmask_in],%[lmask_out]\n" \
>> +                       "   jmp 1b\n" \
>> +                       "   .previous\n" \
>> +                       _ASM_EXTABLE(1b, 2b), \
>> +                       ".byte " pfx "0x0f,0xc7,0x1f\n", \
>> +                       X86_FEATURE_XSAVES, \
>> +                       ASM_OUTPUT2([ptr] "+&D" (ptr), [lmask_out] "+&a" 
>> (lmask)), \
>> +                       [mem] "m" (*ptr), [lmask_in] "g" (lmask), \
>> +                       [hmask] "d" (hmask), [size] "m" (xsave_cntxt_size) \
>> +                       : "ecx")
> 
> Please align the \'s on the RHS.  It makes the resulting blob rather
> easier to read, especially given the \n's in the text.

Well, recent review of one of Roger's patches showed that this is not
generally a good idea, and hence I actually purposefully didn't align
them.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel