[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH XEN v5 07/23] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.
On Tue, 2015-11-24 at 09:34 +0000, Ian Campbell wrote: > Thinking about this some more overnight, it occurred to me that the > real issue is that gnttab and gntshr are actually two quite difference > APIs. gnttab is all about consuming grant references which are given to > you from elsewhere while gntshr is all about creating grant references > to give to others. They have relatively little in common wrt the > underlying infrastructure, e.g. gnttab is mostly about making GNTTABOP > hypercalls while gntshr mostly interacts with the kernel's grant ref > allocator with no interaction with the hypervisor. > > Maybe that and the API issues above constitute an argument for not > combining, I'm really not sure. Ian and I discussed this (briefly) in real life and based on the above argumentation we decided that keeping the two APIs separate (but in the same library) was justified, since there is a reasonable enough air gap between their functionality (i.e. consuming vs producing grants). We did wonder a bit about changing the names to make that divide clearer, but couldn't think of anything especially compelling and decided to stick with the current shade of yellow. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |