[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 1/3] libxl: re-name libxl__xs_write() to libxl__xs_printf()...
> -----Original Message----- > From: Ian Campbell [mailto:ian.campbell@xxxxxxxxxx] > Sent: 24 November 2015 16:23 > To: Ian Jackson; Paul Durrant > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Stefano Stabellini; Wei Liu > Subject: Re: [PATCH v2 1/3] libxl: re-name libxl__xs_write() to > libxl__xs_printf()... > > On Mon, 2015-11-16 at 17:15 +0000, Ian Jackson wrote: > > Paul Durrant writes ("[PATCH v2 1/3] libxl: re-name libxl__xs_write() to > > libxl__xs_printf()..."): > > > ...to denote what it actually does. > > > > > > The name libxl__xs_write() suggests something taking a buffer and > > > length, > > > akin to write(2), whereas the semantics of the function are actually > > > more > > > akin to printf(3). > > > > > > This patch is a textual substitution of libxl__xs_write with > > > libxl__xs_printf with some associated formatting fixes. > > > > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> > > Did you have opinions on the other two patches and/or shall I just apply > this one in the meantime? > Given the discussion (on IRC) about using 'ok' for boolean returns, I'll re-work this patch. Paul > Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |