[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] build: remove .d files from xen/ on a clean
>>> On 24.11.15 at 19:19, <jonathan.creekmore@xxxxxxxxx> wrote: >> On Nov 24, 2015, at 11:30 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote: >> >>>>> On 24.11.15 at 18:22, <jonathan.creekmore@xxxxxxxxx> wrote: >> >>>> On Nov 24, 2015, at 11:16 AM, Jonathan Creekmore >>> <jonathan.creekmore@xxxxxxxxx> wrote: >>>>> On Nov 24, 2015, at 11:07 AM, Jan Beulich <jbeulich@xxxxxxxx> wrote: >>>>>>>> On 24.11.15 at 17:56, <jonathan.creekmore@xxxxxxxxx> wrote: >>>>>> --- a/xen/Makefile >>>>>> +++ b/xen/Makefile >>>>>> @@ -88,7 +88,7 @@ _clean: delete-unfresh-files >>>>>> $(MAKE) -f $(BASEDIR)/Rules.mk -C xsm clean >>>>>> $(MAKE) -f $(BASEDIR)/Rules.mk -C crypto clean >>>>>> $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) clean >>>>>> - rm -f include/asm *.o $(TARGET) $(TARGET).gz $(TARGET).efi >>>>>> $(TARGET)-syms >>> *~ core >>>>>> + rm -f include/asm *.o $(TARGET) $(TARGET).gz $(TARGET).efi >>>>>> $(TARGET)-syms >>> *~ core $(DEPS) >>>>> >>>>> Is this really a problem only in xen/ ? The referenced commit clearly >>>>> introduces "stray" *.d files elsewhere. Also there aren't any source >>>>> files in xen/, so I'd expect $(DEPS) to be empty. Please clarify. >>>> >>>> So, the files in xen/ were the dependencies files for xen.efi and >>>> xen-syms that were getting left behind. $(DEPS) appears to always >>>> have â.*.dâ in it, based on me putting an echo into the clean rule to >>>> print it out. However, looking at this, I am also seeing â.dâ files left >>>> behind in xen/common/compat that I did not notice before. >>> >>> Actually, looking closer at it, xen/common/compat does not appear to be >>> cleaning at all, so I think that is a separate, unrelated issue. >> >> That would be quite related, as it would be a result of the same >> commit. > > Yeah, I now see where that change got introduced. I donât see a clear way of > cleaning > those objects files since the build system no longer goes into the > common/compat directory at > all. The existing clean rules walk all of the subdirectories, cleaning > object files and dependency > files as it goes. But wouldn't the way DEPS gets populated in xen/Rules.mk cover for this? If so, the alternative to your original patch might be to simply rm those ..xen*.o.d files right in the $(TARGET)-syms and $(TARGET).efi rules (along with their corresponding $(@D)/.$(@F).[0-9]* getting removed, due to which those .o.d ones are of no use anyway). Or maybe it should really do both, considering that *.o get removed by _clean too. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |