Re: [Xen-devel] [PATCH 2/9] xen/arm: vgic-v3: Only emulate identification registers requested by the spec

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 16/11/15 13:27, Ian Campbell wrote:
> On Fri, 2015-11-13 at 11:54 +0000, Julien Grall wrote:
>> Most of the identification registers space contains implementation
>> defined registers (see 8.1.13 in ARM IHI 0069A) and only GIC{D,R}_PIDR2
>> is required to be implemented.
> 
> I think you mean s/requested/required/ in the subject too?

Right, I will fix it in the next version.

>>
>> Currently the emulation of those registers mimic the ARM implementation,
>> but it's untrue to say that we properly emulate a such implementation.
>>
>> Keep only GIC{D,R}_PIDR2 implemented with the "implementationd defined
> 
> "implementation"
> 
>> bits" to zero and the ArchRev field (bits[7:4]) to 0x3 as we emulate a
>> GICv3.
>>
>> Note that the emulation of the range wasn't valid anyway because the
>> registers are split in 2 sets (PIDR4-PIDR7 and PIDR0-PIDR2).
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thank you!

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel