Re: [Xen-devel] [PATCH v3 01/62] Revert "xen/arm: vgic-v2: Drop cbase from arch_domain"

[Shannon Zhao <zhaoshenglong@xxxxxxxxxx>]

On 2015/11/17 21:57, Julien Grall wrote:
> On 17/11/15 12:32, Shannon Zhao wrote:
>> > Hi Julien,
>> > 
>> > On 2015/11/17 19:27, Julien Grall wrote:
>>> >> Hi Shannon,
>>> >>
>>> >> Why do you want to revert this patch?
>>> >>
>> > Because d->arch.vgic.cbase will be used by creating Dom0 MADT table
>> > later. See [PATCH v3 43/62].
>> > +            gicc.base_address = d->arch.vgic.cbase;
>> > 
>> > My previous way is get this from ACPI table but someone suggest get it
>> > from struct domain and I think this way is better too since it uses the
>> > value after being parsed.
> It's pointless to store the value in arch_domain for something that it's
> only use during building...
> 
> We have struct kernel_info which store any information related to the
> DOM0 during the building.
> 

Yeah, that would be better if it could use kernel_info. But the problem
is that kernel_info is firstly used in construct_dom0(), while it needs
to store the cbase in domain_create() which is called before
construct_dom0(). And if we pass kernel_info as parameter to
domain_create(), this would introduce more changes to common codes.

Do you have any better idea to handle this?

Thanks,
-- 
Shannon


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel