Re: [Xen-devel] [PATCH XEN v5 19/23] tools/libs/call: Update some log messages to not refer to xc.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/11/15 12:00, Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I agree with the sentiment, but the error message refer to the
libxencall entry API, so a developer can match it back to the call in
their code.

~Andrew

> ---
>  tools/libs/call/linux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libs/call/linux.c b/tools/libs/call/linux.c
> index 906ca7e..80b505c 100644
> --- a/tools/libs/call/linux.c
> +++ b/tools/libs/call/linux.c
> @@ -88,7 +88,7 @@ void *osdep_alloc_pages(xencall_handle *xcall, unsigned int 
> npages)
>      p = mmap(NULL, size, PROT_READ|PROT_WRITE, 
> MAP_PRIVATE|MAP_ANONYMOUS|MAP_LOCKED, -1, 0);
>      if ( p == MAP_FAILED )
>      {
> -        PERROR("xc_alloc_hypercall_buffer: mmap failed");
> +        PERROR("alloc_pages: mmap failed");
>          return NULL;
>      }
>  
> @@ -97,7 +97,7 @@ void *osdep_alloc_pages(xencall_handle *xcall, unsigned int 
> npages)
>      rc = madvise(p, npages * PAGE_SIZE, MADV_DONTFORK);
>      if ( rc < 0 )
>      {
> -        PERROR("xc_alloc_hypercall_buffer: madvise failed");
> +        PERROR("alloc_pages: madvise failed");
>          goto out;
>      }
>  


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel