Re: [Xen-devel] [PATCH v5 1/9] libxc: reorganize domain builder guest memory allocator

[Juergen Gross <jgross@xxxxxxxx>]

On 12/11/15 14:48, Wei Liu wrote:
> On Thu, Nov 12, 2015 at 02:43:28PM +0100, Juergen Gross wrote:
>> Guest memory allocation in the domain builder of libxc is done via
>> virtual addresses only. In order to be able to support preallocated
>> areas not virtually mapped reorganize the memory allocator to keep
>> track of allocated pages globally and in allocated segments.
>>
>> This requires an interface change of the allocate callback of the
>> domain builder which currently is using the last mapped virtual
>> address as a parameter. This is no problem as the only user of this
>> callback is stubdom/grub/kexec.c using this virtual address to
>> calculate the last used pfn.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> 
> If you've tested and confirmed pvgrub (stubdom based grub) doesn't
> break:
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 

Hmm, difficult. Is this ever tested automatically? I just tried and
it died:

...
vbd 51712 is hd0
******************* BLKFRONT for device/vbd/51712 **********
backend at /local/domain/0/backend/qdisk/3/51712
Failed to read /local/domain/0/backend/qdisk/3/51712/feature-barrier.
16777216 sectors of 0 bytes
**************************

I guess I need a special setup to make it work. :-(


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel