Re: [Xen-devel] [raisin][PATCHv2] Handle unsupported distros with a prettier message

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 11 Nov 2015, Doug Goldstein wrote:
> Handle unknown distros by saying "unknown" instead of an empty string
> and for Gentoo users actually mention it.
> 
> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>

Thanks for the patch.


>  lib/common-functions.sh | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/lib/common-functions.sh b/lib/common-functions.sh
> index 27f6434..a0b8431 100644
> --- a/lib/common-functions.sh
> +++ b/lib/common-functions.sh
> @@ -150,8 +150,16 @@ function get_distro() {
>                       sed -r 's/\"|\(|\)//g' | awk '{print $2}'`
>          os_RELEASE=`awk '/VERSION_ID=/' /etc/os-release | sed 
> 's/VERSION_ID=//' \
>                      | sed 's/\"//g'`
> +    elif [[ -f /etc/gentoo-release ]]
> +    then
> +        os_VENDOR="Gentoo"
>      fi
>  
> +    if [[ -z $os_VENDOR ]]
> +     then
> +             os_VENDOR="unknown"
> +     fi

Spaces no tabs, please :-)

If you are going to resend, I would prefer to set os_VENDOR to "unknown"
at the beginning of the function and avoid the if.



>      # Simply distro version string
>      case "$os_VENDOR" in
>          "Debian"* | "Ubuntu"* | "LinuxMint"* )
> -- 
> 2.4.10
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel