Re: [Xen-devel] [PATCH v3 2/2] arm: export platform_op XENPF_settime64

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 11 Nov 2015, Julien Grall wrote:
> Hi Stefano,
> 
> On 11/11/15 17:19, Stefano Stabellini wrote:
> > Call update_domain_wallclock_time at domain initialization.
> > Set time_offset_seconds to the number of seconds between physical boot
> > and domain initialization: it is going to be used to get/set the
> > wallclock time.
> > Add time_offset_seconds to system_time when before calling do_settime,
> > so that system_time actually accounts for all the time in nsec between
> > machine boot and when the wallclock was set.
> 
> + Expose the xsm_platform_op to ARM
> 
> + Add the prototype of ticks_to_ns in the headers
> 
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > Acked-by: dgdegra@xxxxxxxxxxxxx
> > CC: dgdegra@xxxxxxxxxxxxx
> > 
> > ---
> 
> [...]
> 
> > diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
> > index 1418092..aa0fde6 100644
> > --- a/xen/arch/arm/vtimer.c
> > +++ b/xen/arch/arm/vtimer.c
> > @@ -22,13 +22,13 @@
> >  #include <xen/timer.h>
> >  #include <xen/sched.h>
> >  #include <xen/perfc.h>
> > +#include <asm/div64.h>
> >  #include <asm/irq.h>
> >  #include <asm/time.h>
> >  #include <asm/gic.h>
> >  #include <asm/vgic.h>
> >  #include <asm/regs.h>
> >  
> > -extern s_time_t ticks_to_ns(uint64_t ticks);
> 
> If it's a valid change you should mention it in the commit message
> because it's not related to this patch.
> 
> Otherwise it looks spurious...

Sorry, that's not a valid change anymore, I meant to remove it. Thanks
for checking.


> > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> > index fafb1a4..680485e 100644
> > --- a/xen/xsm/flask/hooks.c
> > +++ b/xen/xsm/flask/hooks.c
> > @@ -1735,6 +1735,7 @@ static struct xsm_operations flask_ops = {
> >      .deassign_dtdevice = flask_deassign_dtdevice,
> >  #endif
> >  
> > +    .platform_op = flask_platform_op,
> 
> Please build test Xen with XSM enabled, I'm nearly sure you that you
> need to move the function flask_platform_op out of the #ifdef CONFIG_X86.
 
Yes, you are right. Besides flask_platform_op, I found another issue
that way.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel