[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 5/8] xen: arm: add interfaces to save/restore the state of a PPI.
On Wed, 2015-11-11 at 12:49 +0000, Julien Grall wrote: >Â > > +ÂÂÂÂif ( s->enabled ) > > +ÂÂÂÂÂÂÂÂgicv2_irq_disable(desc); > > Don't we want to disable the IRQ first and then saving the state? We need at least the enable/disable state first. Perhaps some of the other stuff might be better done afterwards, I'll have a think. > > Â > > +static void gicv3_save_and_mask_hwppi(struct irq_desc *desc, > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂstruct hwppi_state *s) > > +{ > > +ÂÂÂÂconst unsigned int mask = (1u << desc->irq); > > +ÂÂÂÂconst unsigned int pendingr = readl_relaxed(GICD_RDIST_SGI_BASE + > > GICR_ISPENDR); > > +ÂÂÂÂconst unsigned int activer = readl_gicd(GICD_RDIST_SGI_BASE + > > GICR_ISACTIVER); > > +ÂÂÂÂconst unsigned int enabler = readl_gicd(GICD_RDIST_SGI_BASE + > > GICR_ISENABLER); > > Those registers don't exists. Did you try to build the GICv3 code? I thought so (and was a bit surprised there were apparently all the right defines in place). But actually I was building for arm32 and had forgotten that doesn't build gicv3. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |