Re: [Xen-devel] [OSSTEST PATCH 02/22] cs-adjust-flight: Allow adjusting "this" flight

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-11-10 at 19:53 +0000, Ian Jackson wrote:
> This allows cs-adjust-flight to be run by hand to adjust runvars, in a
> flight being used with hand-invocation of ./ts-* scripts.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
> v14: New patch
> ---
> Âcs-adjust-flight |ÂÂÂÂ8 ++++++++
> Â1 file changed, 8 insertions(+)
> 
> diff --git a/cs-adjust-flight b/cs-adjust-flight
> index d70abf7..7c2c384 100755
> --- a/cs-adjust-flight
> +++ b/cs-adjust-flight
> @@ -28,6 +28,7 @@
> Â# <dst-flight>:
> Â#ÂÂÂ<flight>
> Â#ÂÂÂnew:<intended-blessing>
> +#ÂÂÂrunning:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂuses OSSTEST_FLIGHT (may be `constructing' too)

I understanding the parenthetical to mean that the flight referenced by
$OSSTEST_FLIGHT is allowed to have a current (not intended) blessing of
`constructing' as well as the `running' implied by the option name, but I
suspect that other than you I'm one of the few people familiar enough with
osstest to reach that conclusion.

It's a bit verbose but I think I would make it say something like "(the
referenced flight must currently be blessed either `running' or
`constructing')"

> Â#
> Â# options:
> Â#ÂÂÂ-vÂÂÂÂÂÂÂÂÂÂÂÂÂÂverbose - list changes to stderr
> @@ -395,6 +396,13 @@ sub main () {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂverbose_discard();
> ÂÂÂÂÂÂÂÂÂÂÂÂÂchanges();
> ÂÂÂÂÂÂÂÂÂ});
> +ÂÂÂÂ} elsif ($dstflightspec =~ m/^running:$/) {
> +ÂÂÂÂÂÂÂÂ$dstflight = $ENV{OSSTEST_FLIGHT} // die;
> +ÂÂÂÂÂÂÂÂdb_retry($dstflight,[qw(constructing running)],
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ$dbh_tests, [qw(flights)], sub {
> +ÂÂÂÂÂÂÂÂÂÂÂÂverbose_discard();
> +ÂÂÂÂÂÂÂÂÂÂÂÂchanges();
> +ÂÂÂÂÂÂÂÂ});

The actual code looks fine to me.

> ÂÂÂÂÂ} elsif ($dstflightspec =~ m/^new:/) {
> ÂÂÂÂÂÂÂÂÂmy $intended = $'; #';
> ÂÂÂÂÂÂÂÂÂdb_retry($dbh_tests, [qw(flights)], sub {
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel