[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 4/4] x86/traps: honor EXT bit in error codes
>>> On 10.11.15 at 19:20, <andrew.cooper3@xxxxxxxxxx> wrote: > On 10/11/15 17:40, Jan Beulich wrote: >> @@ -3257,7 +3262,7 @@ void do_general_protection(struct cpu_us >> * instruction. The DPL specified by the guest OS for these vectors is >> NOT >> * CHECKED!! >> */ >> - if ( (regs->error_code & 3) == 2 ) >> + if ( regs->error_code & X86_XEC_IDT ) > > The code here has changed. It is still technically correct because EXT > breaks earlier, but please do update the comment which currently talks > about the EXT check you have just removed. It talks about it, yes, but not in a way making it incompatible with the code after the change. Anyway, I inserted "which got already checked above". Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |